----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/#review66865 -----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp <https://reviews.apache.org/r/29289/#comment110543> why are you adding seed as an argument then immediately overriding it in the body of the function? 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment110545> why change the type of family? 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment110544> the API is more complex here, which seems like a regression. Is it possible to simplify this? sockaddr_in addr = net::createSockaddrIn(net::IP::Address(), 0); ? though I suppose actually the accept call should be wrapped up now and use the Address abstraction, so maybe this is a temporary change? 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment110546> better TODO: add a bind wrapper at the lower layer to abstcract this away completely. - Dominic Hamon On Jan. 6, 2015, 6:17 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29289/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 6:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class Address encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/node.hpp > 173eb8abe0d0930c92f261be7a95e07b1d4c16af > 3rdparty/libprocess/include/process/pid.hpp > 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 > 3rdparty/libprocess/include/process/socket.hpp > ddb9e365fc1e65a568bdac4973964df1ab8cc05e > 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d > 3rdparty/libprocess/src/process.cpp > 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf > > Diff: https://reviews.apache.org/r/29289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
