> On Nov. 8, 2014, 1:19 a.m., Ben Mahler wrote: > > Thanks for following up Joris!! Didn't look at the forking code since we > > might be able to avoid per (2): > > > > (1) Hm.. it might be easier for someone to understand how this benchmark > > works if we change the names of these processes to `ClientProcess` and > > `ServerProces`, from `PingerProcess` and `PongerProcess`, respectively. > > After which, let's rewrite the comments above the classes to be a bit less > > low-level. > > > > (2) Could we pull the client and server out into separate programs? That > > way, we could get two key benefits. First, we can start the server and as > > many clients as we like manually as well, and we can run the benchmark > > using http requests. That might make it a bit easier for us to collect > > `perf` traces of say, only the server process. Second, and less important, > > we might be able to leverage `Subprocess` to avoid the complicated forking > > logic currently in place. > > > > Let me know if I missed anything!
Just to be clear, please feel free to punt with TODOs for (2)! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review60425 ----------------------------------------------------------- On Oct. 24, 2014, 8:46 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27113/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 8:46 p.m.) > > > Review request for mesos, Ben Mahler and Niklas Nielsen. > > > Bugs: MESOS-1980 > https://issues.apache.org/jira/browse/MESOS-1980 > > > Repository: mesos-git > > > Description > ------- > > Add a comment to BenchmarkProcess. > Remove setLink() as it is not strictly necessary. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8e > > Diff: https://reviews.apache.org/r/27113/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
