> On Jan. 6, 2015, 6:02 p.m., Timothy Chen wrote: > > include/mesos/mesos.hpp, line 28 > > <https://reviews.apache.org/r/29599/diff/1/?file=807131#file807131line28> > > > > It seems odd to just bulk paste it in mesos.hpp. > > If we really need to expose this, can we introduce a new hpp file > > instead?
I agree. The pasted code corresponds to the definitions in mesos.pb.h. Do you have a suggestion for a filename for this block? > On Jan. 6, 2015, 6:02 p.m., Timothy Chen wrote: > > src/common/type_utils.cpp, line 22 > > <https://reviews.apache.org/r/29599/diff/1/?file=807133#file807133line22> > > > > Is this needed? This file uses UUID and so it seemed appropriate to have this #include. Having said that, this file is also included in the corresponding hpp file and so one can get away without adding this line. Unless there is a strong preference, I would like to keep it as is. > On Jan. 6, 2015, 6:02 p.m., Timothy Chen wrote: > > src/tests/registrar_tests.cpp, line 34 > > <https://reviews.apache.org/r/29599/diff/1/?file=807135#file807135line34> > > > > Is this needed? Yes, due to the Attributes type used later in this file. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29599/#review66936 ----------------------------------------------------------- On Jan. 6, 2015, 5:39 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29599/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 5:39 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [2/9] Build Mesos Modules outside Mesos source tree. > > These operators correspond to the protobufs declared in mesos.proto. Since > mesos.hpp (that includes mesos.pb.h) exposes these protobus, these > definitions also need to be exposed. > > > Diffs > ----- > > include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 > src/slave/state.hpp 592182b21ae2700c627f180db38ca5dc1b3c9e8a > src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f > > Diff: https://reviews.apache.org/r/29599/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
