> On Dec. 29, 2014, 11:01 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 24-26 > > <https://reviews.apache.org/r/29406/diff/1/?file=800352#file800352line24> > > > > Let's give these defaults, and some comments explaining their purpose > > please!
I'm leaving this and some of the other openssl comments until we rebase on BenH's introduction of these as a separate commit. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review66306 ----------------------------------------------------------- On Jan. 7, 2015, 12:16 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29406/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 12:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1913 > https://issues.apache.org/jira/browse/MESOS-1913 > > > Repository: mesos-git > > > Description > ------- > > Requires: > configure --enable-libevent --enable-libevent-socket --enable-ssl > New environment variables: > USE_SSL=(0,1) > SSL_CERT=(path to certificate) > SSL_KEY=(path to key) > SSL_VERIFY_CERT=(0,1) > SSL_REQUIRE_CERT=(0,1) > SSL_CA_DIR=(path to CA directory) > SSL_CA_FILE=(path to CA file) > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0 > 3rdparty/libprocess/include/process/socket.hpp > 7e1e3f22583f44a9aea8259bafedc2877ad2e633 > 3rdparty/libprocess/src/libevent.hpp PRE-CREATION > 3rdparty/libprocess/src/libevent.cpp PRE-CREATION > 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 028b33e7ecb7e0a39334ac4ab0279ee327a72a56 > 3rdparty/libprocess/src/socket.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29406/diff/ > > > Testing > ------- > > make check (uses non-ssl socket) > benchmarks using ssl sockets > master, slave, framework, webui launch with ssl sockets > > > Thanks, > > Joris Van Remoortere > >
