----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29473/#review66958 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29473/#comment110698> Let's keep the indenting consistent, 2 spaces please! include/mesos/mesos.proto <https://reviews.apache.org/r/29473/#comment110700> Remove this newline, to be consistent with the rest of our protobufs. src/common/http.cpp <https://reviews.apache.org/r/29473/#comment110701> Please use braces on your if statements, to be consistent with the rest of our code. src/common/protobuf_utils.cpp <https://reviews.apache.org/r/29473/#comment110702> Please keep the indenting consistent, 2 spaces here. - Ben Mahler On Jan. 6, 2015, 5:04 p.m., Christos Kozyrakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29473/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 5:04 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, Niklas > Nielsen, Timothy Chen, and Timothy St. Clair. > > > Bugs: MESOS-2150 > https://issues.apache.org/jira/browse/MESOS-2150 > > > Repository: mesos-git > > > Description > ------- > > These are the Mesos changes needed to accomodate service discovery > information for tasks (see MESOS-2150). > If the frameworks launch task with service discovery info, it is made > available through the master state.json endpoint. > > > Diffs > ----- > > include/mesos/mesos.proto 540071d > src/common/http.cpp 0d0d52f > src/common/protobuf_utils.cpp 8ab5cdd > src/master/master.cpp d6651e2 > src/messages/messages.proto 16043dd > src/tests/master_tests.cpp 7f796be > > Diff: https://reviews.apache.org/r/29473/diff/ > > > Testing > ------- > > Added TaskDiscoveryInfo to MasterTest that verifies that service discovery > info appears correctly on state.json. > Passed all existing tests (make check). > > > Thanks, > > Christos Kozyrakis > >
