----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28608/#review67118 -----------------------------------------------------------
Hm.. per my comment below, it looks like this depends on r/28809 (rather than the other way around). src/slave/slave.hpp <https://reviews.apache.org/r/28608/#comment110944> Given this comment, does this approach work for the existing Docker containerizer? Or will the symlinks become invalid? src/slave/slave.cpp <https://reviews.apache.org/r/28608/#comment110945> It seems a bit odd to be preparing these blindly, without validating that we first know about these resources. Is there any reason that this review comes before r/28809/? It looks like it should come afterwards. src/slave/slave.cpp <https://reviews.apache.org/r/28608/#comment110946> Here and elsewhere where you're CHECKing these things, we might want to have a comment saying that the master validates these things. src/slave/slave.cpp <https://reviews.apache.org/r/28608/#comment110941> Is this being validated in the master to prevent this check from failing in the slave? src/slave/slave.cpp <https://reviews.apache.org/r/28608/#comment110943> Do you need to be CHECKing that the container path is non-empty, and has valid characters for a directory name? And are we catching these things in the master? - Ben Mahler On Dec. 2, 2014, 10:01 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28608/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 10:01 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos-git > > > Description > ------- > > Allowed slave to create and link persistent volumes. > > > Diffs > ----- > > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5 > > Diff: https://reviews.apache.org/r/28608/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
