-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 4:49 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van
Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and
an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container
filters, but write different encode/decode functions for IPv4/ICMP and
IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/linux/routing/diagnosis/diagnosis.cpp
136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp
2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
src/tests/master_contender_detector_tests.cpp
d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca
src/tests/routing_tests.cpp 962cff27652d8589dc0f7d3b1ecc6d81ef9d1f23
Diff: https://reviews.apache.org/r/29290/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
