> On Jan. 8, 2015, 11:46 a.m., Ian Downes wrote: > > src/tests/disk_quota_tests.cpp, line 164 > > <https://reviews.apache.org/r/29690/diff/1/?file=810333#file810333line164> > > > > suggest using "bs=1M count=2" to make it clearer we'll exceed the 1M > > disk quota set in the resources. > > > > Use `dd && sleep` so we fail if there's an issue with dd. > > Ian Downes wrote: > hmm, dd on osx and linux differ - one only accepts 1M and the other only > accepts 1m. > > Jie Yu wrote: > Yeah, that's exactly the reason I used bs=1024:)
Unfortunated :-( Any reason you're doing 4MB compared to the 1MB quota then? I would've done "bs=1048576 count=2", i.e., 2 units of the quota. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29690/#review67268 ----------------------------------------------------------- On Jan. 7, 2015, 4:45 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29690/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 4:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added an integration test for enforcing disk quota. > > > Diffs > ----- > > src/tests/disk_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29690/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
