----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29746/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu. Repository: mesos-git Description ------- Performs the resource operations in LaunchTasks. The removed validation code for persistent disks will need to be reworked into either `Resources::validate(const Resource::Operation::(Create/Destroy)PersistentDisks &)` or `Resources::Transform::operator()` depending on what type of error we're checking for. Diffs ----- src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e Diff: https://reviews.apache.org/r/29746/diff/ Testing ------- make check. **NOTE**: `TaskValidationTest`s that involve invalid persistent disks fail because the error messages don't match. I could simply remove the error message check to make them pass but we actually need to move these tests to a different place now that we don't do implicit create/destroy of persistent disks via `TaskInfo` anymore. Not fixed on purpose to make sure I remember. Thanks, Michael Park
