----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/#review67411 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/29606/#comment111433> Thanks for this fix. src/authentication/authenticatee.hpp <https://reviews.apache.org/r/29606/#comment111434> Thanks for this fix as well. src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/29606/#comment111441> Insert new line? src/authentication/cram_md5/authenticator.hpp <https://reviews.apache.org/r/29606/#comment111440> Insert new line. src/master/master.hpp <https://reviews.apache.org/r/29606/#comment111439> Ordering and spacing? ``` #include <mesos/resources.hpp> #include <mesos/module/authenticator.hpp> ``` src/master/master.cpp <https://reviews.apache.org/r/29606/#comment111437> Insert a blank line as this is a "new" subfolder. src/sched/sched.cpp <https://reviews.apache.org/r/29606/#comment111438> IIUC, the correct spacing and ordering is as follows, no? ``` #include <mesos/mesos.hpp> #include <mesos/module.hpp> #include <mesos/scheduler.hpp> #include <mesos/module/authenticatee.hpp> ``` src/scheduler/scheduler.cpp <https://reviews.apache.org/r/29606/#comment111435> IIUC the correct ordering and spacing would be, no? ``` #include <mesos/mesos.hpp> #include <mesos/scheduler.hpp> #include <mesos/module/authenticatee.hpp> ``` src/slave/slave.hpp <https://reviews.apache.org/r/29606/#comment111436> Insert a blank line as this is a "new" subfolder. - Till Toenshoff On Jan. 6, 2015, 10:39 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29606/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:39 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [9/9] Build Mesos Modules outside Mesos source tree. > > This allows authentication modules to be built outside the mesos source tree. > > > Diffs > ----- > > src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 > src/authentication/authenticatee.hpp > 361083b5e1ca5ab1a594b3108fb768626313a725 > src/authentication/authenticator.hpp > 460494a49ad7c71803507afe62005280d5929d41 > src/authentication/cram_md5/authenticatee.hpp > 5d35598f75f4d9a8c185cfd387e1085b3bf15395 > src/authentication/cram_md5/authenticator.hpp > d739a02d755c2729248291db8c274ad7e7dd4c6d > src/examples/test_authentication_modules.cpp > 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65 > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd > src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2 > src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3 > src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > src/tests/cram_md5_authentication_tests.cpp > a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736 > > Diff: https://reviews.apache.org/r/29606/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
