----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29341/#review67650 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29341/#comment111714> typo contianer -> container src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29341/#comment111715> 1. What does this do? A comment would be nice. 2. Depending on what the above reveals, reusing the volume variable may not be tidy. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29341/#comment111717> 1. What pid in what host? Can you be more specific? 2. How does this relate to the following statement? By it not referring to the mentioned pid? Can you make that more explicit? Or would you like the reader to look up what ResourceStatistics() does and then find it "obvious"? - Bernd Mathiske On Jan. 8, 2015, 5:30 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29341/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 5:30 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Fix docker recovery when launched in container and add more logging. > Also delay removing the executor container so it can be introspected as well > as the container. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > > Diff: https://reviews.apache.org/r/29341/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
