----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29336/#review67660 -----------------------------------------------------------
This code was relatively hard to get into. Please be generous with strategy/overview comments! src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111722> According to review #29341 this is wrong. See your updated solution there! The latter seems to be the correct one to me. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111723> This method is now officially too large. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111724> This could be broken out and given a nice method name. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111725> Another section that could be in its own method starts here. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111726> executorPid? waitPid? lastExecutorRunPid? containerPid? I am guessing the former. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111731> This can be broken out, too. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111732> that pid of the -> the pid of whose src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29336/#comment111734> a -> an - Bernd Mathiske On Jan. 8, 2015, 5:25 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29336/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 5:25 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Recover docker containers that launched in containers. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > > Diff: https://reviews.apache.org/r/29336/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
