----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29809/#review67669 -----------------------------------------------------------
src/launcher/fetcher.cpp <https://reviews.apache.org/r/29809/#comment111744> Why would someone put a fetch URI with a NONE action? src/launcher/fetcher.cpp <https://reviews.apache.org/r/29809/#comment111739> More description what this is? "Fetching '" << uri.value() << "' with mode 'NONE'"; src/launcher/fetcher.cpp <https://reviews.apache.org/r/29809/#comment111745> This block seems to be repeated 3 times, can we extract this? src/launcher/fetcher.cpp <https://reviews.apache.org/r/29809/#comment111742> IMO this should be LOG(FATAL) src/slave/containerizer/fetcher.cpp <https://reviews.apache.org/r/29809/#comment111746> Why empty file? - Timothy Chen On Jan. 12, 2015, 3:40 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29809/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 3:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2069 > > > Repository: mesos-git > > > Description > ------- > > Enhanced the fetcher program (launcher/fetcher.cpp) with fetcher cache > "actions" and an additional parameter in FetchrInfo: the cache filenames to > be used for these actions. > > > Diffs > ----- > > include/mesos/fetcher/fetcher.proto > facb87b92bf3194516f636dcc348e136af537721 > src/launcher/fetcher.cpp fed0105 > src/slave/containerizer/fetcher.hpp > 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp > 5993670f7899233efa1e6acef4b0c7856e32f748 > > Diff: https://reviews.apache.org/r/29809/diff/ > > > Testing > ------- > > make check. > > For now it is OK if only the FETCH action works, which implements the legacy > behavior without any caching. > > The new functionality will be tested in the context of MESOS-2074. > > > Thanks, > > Bernd Mathiske > >
