----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29815/#review67708 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolator.hpp <https://reviews.apache.org/r/29815/#comment111789> How about just saying: ``` // NOTE: 'Resources' is used here because the resource may // span multiple roles (e.g. `"mem(*):1;mem(role):2"`). ``` Or are there other reasons for storing Resources? src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/29815/#comment111788> Or if the resource spans roles (e.g. `"*"` and `"role"`), right? - Ben Mahler On Jan. 12, 2015, 6:46 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29815/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 6:46 p.m.) > > > Review request for mesos, Ben Mahler and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Used resources instead of resource in Limitation. This is needed by the disk > quota isolator. > > > Diffs > ----- > > src/slave/containerizer/isolator.hpp > e82a14201f734292a46b8816c894fa8c766dae5a > src/slave/containerizer/isolators/cgroups/mem.cpp > 71f4b9b3885ccb1c9e5ad589e65be06045030f19 > src/slave/containerizer/mesos/containerizer.cpp > 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 > > Diff: https://reviews.apache.org/r/29815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
