> On Jan. 7, 2015, 4:13 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.cpp, line 529 > > <https://reviews.apache.org/r/29328/diff/1/?file=798948#file798948line529> > > > > While you are editing this code, you may opt to also make this > > pre-existing comment more clear. It is somewhat misleading in that the > > comment seems to cover both parts of this statement, but it only really > > covers the first clause. Suggestion: > > "Get the list of all Docker containers (...) and then remove any > > orphans." > > Timothy Chen wrote: > Hmm, the comment seems to suggest just the first clause? it's getting the > list "in order" to remove the orphans. BenH originally wrote this comment I > think it's fine as-is.
Or maybe something along the lines of: // Get the list of all the running containers so that we can remove any orphans that we find. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29328/#review67030 ----------------------------------------------------------- On Jan. 9, 2015, 1:20 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29328/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 1:20 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Add option to disable docker containerizer killing orphans > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 5f4b4ce > src/slave/flags.hpp f1b8dfb > > Diff: https://reviews.apache.org/r/29328/diff/ > > > Testing > ------- > > > make check > > > Thanks, > > Timothy Chen > >
