> On Jan. 12, 2015, 11:29 p.m., Ben Mahler wrote: > > Mind clarifying that it's the just the C++ API in your review summary / > > commit message?
Sure. > On Jan. 12, 2015, 11:29 p.m., Ben Mahler wrote: > > src/sched/sched.cpp, lines 965-966 > > <https://reviews.apache.org/r/29823/diff/1/?file=818010#file818010line965> > > > > "not been" or just "acceptOffers is unimplemented" > > > > Looksl like we should call error here? > > > > ``` > > LOG(ERROR) << "acceptOffers is unimplemented"; > > error("acceptOffers is unimplemented"); > > ``` Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29823/#review67738 ----------------------------------------------------------- On Jan. 12, 2015, 9:42 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29823/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 9:42 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added accept offers to the old scheduler API. > > > Diffs > ----- > > include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e > src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 > > Diff: https://reviews.apache.org/r/29823/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
