----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/#review67963 -----------------------------------------------------------
src/examples/test_hook_module.cpp <https://reviews.apache.org/r/29496/#comment112046> s/temp/temporary/ src/tests/hook_tests.cpp <https://reviews.apache.org/r/29496/#comment112048> kill newline src/tests/hook_tests.cpp <https://reviews.apache.org/r/29496/#comment112050> Can you add that you are testing that the test hook hangs a new label off the taskinfo? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29496/#comment112051> Also here; can you add that you expect one hook to create a temporary file and the other to clean it up? - Niklas Nielsen On Jan. 13, 2015, 10:37 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29496/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 10:37 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > This module provides hooks for master label decorator, slave executor > environment decorator and slave remove executor. A couple of test cases are > also provided to verify the hooks from this module. > > > Diffs > ----- > > src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 > src/examples/test_hook_module.cpp PRE-CREATION > src/tests/hook_tests.cpp PRE-CREATION > src/tests/module.hpp bc1a37df7f95e945363418429fef4d090907c73a > src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4 > > Diff: https://reviews.apache.org/r/29496/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
