> On Jan. 13, 2015, 5:26 p.m., Niklas Nielsen wrote: > > src/hook/hook.hpp, lines 22-24 > > <https://reviews.apache.org/r/28655/diff/6/?file=819518#file819518line22> > > > > Do you have an example where mesos.hpp is included before stout headers?
I just did a `grep "mesos.mesos.hpp" -A4 src/* -nr` and it showed up at a lot of places :-). > On Jan. 13, 2015, 5:26 p.m., Niklas Nielsen wrote: > > src/hook/manager.cpp, lines 79-80 > > <https://reviews.apache.org/r/28655/diff/6/?file=819520#file819520line79> > > > > How about making labels an option type? I am thinking whether we can > > get rid of the bool :) Updated code doesn't have the bool. > On Jan. 13, 2015, 5:26 p.m., Niklas Nielsen wrote: > > src/master/master.cpp, line 2835 > > <https://reviews.apache.org/r/28655/diff/6/?file=819523#file819523line2835> > > > > Should we print a warning is labels is error? Added the warning message in hookmanager. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/#review67956 ----------------------------------------------------------- On Jan. 13, 2015, 7:36 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28655/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:36 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > Hooks are implemented as Mesos modules. The first hook is a task > label-decorator that is called during the task launch sequence in Mesos > master. > > This hook allows hook modules to add additional labels to the incoming > TaskInfo object. The labels are then read on the slave/executor side which > may then act upon them. > > > Diffs > ----- > > src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/master/flags.hpp f5c8d2a8cc7530bc8746935af9ea90af747cc111 > src/master/main.cpp 193d53f13d8b14638b311cc290b5a5802ea56299 > src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e > src/module/hook.hpp PRE-CREATION > src/module/manager.cpp 5e779e4c565ee13206cee59e9097499320474187 > > Diff: https://reviews.apache.org/r/28655/diff/ > > > Testing > ------- > > Added two tests (see https://reviews.apache.org/r/29496/) and ran make check. > > > Thanks, > > Kapil Arya > >
