> On Jan. 14, 2015, 6:38 p.m., Dominic Hamon wrote: > > can you use the 'depends on' to avoid containing other RBs?
This review is not meant to be merged, sorry probably should have put this on the description. Since my changes spans lots of reviews, it's easier to have one diff to see everything. In my other review chain it has the depends on populated. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review68064 ----------------------------------------------------------- On Jan. 14, 2015, 6:35 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29889/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 6:35 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > This is a one mega patch and contains many reviews that's already on rb. > > > Diffs > ----- > > Dockerfile 35abf25 > src/Makefile.am fc0c322 > src/docker/docker.hpp 3ebbc1f > src/docker/docker.cpp 3a485a2 > src/docker/executor.cpp PRE-CREATION > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > src/slave/flags.hpp f1b8dfb > src/tests/docker_containerizer_tests.cpp 2105ae2 > > Diff: https://reviews.apache.org/r/29889/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
