----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29913/#review68190 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/29913/#comment112344> I'm uncertain whether this is the correct behavior here. If recoverResources fails, it probably means either there's a bug, or perhaps the user manually modified the checkpoint file. But I presume modifying the checkpoint file isn't something we allow nor want users to do, so I went with a `CHECK` for now. Perhaps `validatePersistedResources` should be `checkPersistedResources` in which we perform `CHECK`s? Please advise. - Michael Park On Jan. 15, 2015, 2:04 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29913/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 2:04 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Added persisted resources validation on the slave side. > > > Diffs > ----- > > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > > Diff: https://reviews.apache.org/r/29913/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
