----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29926/#review68303 -----------------------------------------------------------
This is an extremely common pattern in the code, and so we should avoid doing it in an inconsistent manner. FWIW, we've yet to see leaks from this pattern, but if you want to make this change, let's do it as a broad sweep instead of introducing inconsistent code. :) - Ben Mahler On Jan. 15, 2015, 4:58 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29926/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 4:58 p.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/allocation/allocator.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29926/diff/ > > > Testing > ------- > > make check (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
