----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29948/#review68343 -----------------------------------------------------------
Ship it! Thanks Mpark! - Niklas Nielsen On Jan. 15, 2015, 2:15 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29948/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 2:15 p.m.) > > > Review request for mesos, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2049 and MESOS-2227 > https://issues.apache.org/jira/browse/MESOS-2049 > https://issues.apache.org/jira/browse/MESOS-2227 > > > Repository: mesos-git > > > Description > ------- > > `circular_buffer` uses `memset` to assign elements. We were using > `circular_buffer<MonitoringInfo>`, `MonitoringInfo` contains `ExecutorInfo`, > and `ExecutorInfo` is a dynamic class (due to some protobuf implementation > probably). > > The default warning levels on clang tells us that we can't simply perform > `memset` on dynamic classes because we'll overwrite the vtable pointer which > will lead to badness. > > This patch fixes the issue by using `circular_buffer<Owned<MonitoringInfo>>` > instead, which is what we do across the codebase wherever we use > `circular_buffer`. > > > Diffs > ----- > > src/slave/monitor.hpp 02b2ce1619c87296ee8c90f6363e77d070dd598d > src/slave/monitor.cpp 1c02986e22bc1dcbc2f07de546bf865d34c41c89 > > Diff: https://reviews.apache.org/r/29948/diff/ > > > Testing > ------- > > make check with `clang-3.5` > > > Thanks, > > Michael Park > >
