----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/#review68342 -----------------------------------------------------------
src/slave/containerizer/isolators/posix/disk.hpp <https://reviews.apache.org/r/29895/#comment112523> At this point, is it worth having single map with a struct capturing these values? e.g. ``` struct QuotaInfo { Resources quota; Future<Bytes> usage; Option<Bytes> lastUsage; }; hashmap<std::string, QuotaInfo> quotas ``` It looks a bit tricky to keep all of these maps in sync. src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/29895/#comment112524> This doesn't check the third map? src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/29895/#comment112538> All of the other isolators (mem, cpu) return a failure for this case, why is this a VLOG + successful future? ``` if (!infos.contains(containerId)) { return Failure("Unknown container"); } ResourceStatistics result; ... ``` src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/29895/#comment112539> ``` // NOTE: There may be a large delay (# of containers * interval) // until an initial cached value is returned here! if (!info->cached.contains(info->directory)) { ... } ``` src/tests/disk_quota_tests.cpp <https://reviews.apache.org/r/29895/#comment112540> // NOTE: We can't pause the clock because we need the reaper to reap the 'du' subprocess. src/tests/disk_quota_tests.cpp <https://reviews.apache.org/r/29895/#comment112541> EXPECT_EQ(Megabytes(3), Bytes(usage.get().disk_limit_bytes()); - Ben Mahler On Jan. 14, 2015, 8:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29895/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 8:30 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added disk usage statistics reporting. This allow the isolator to report > resource statistics for disk (sandbox). > > > Diffs > ----- > > include/mesos/mesos.proto 5007c0c58c5573ef19163c2c58cc3a7c5b555f46 > src/slave/containerizer/isolators/posix/disk.hpp PRE-CREATION > src/slave/containerizer/isolators/posix/disk.cpp PRE-CREATION > src/tests/disk_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29895/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
