> On Jan. 17, 2015, 12:18 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, lines 160-161 > > <https://reviews.apache.org/r/29896/diff/2/?file=824243#file824243line160> > > > > Let's clarify this one: > > > > For example: > > "... to check the overall disk usage managed by the slave, this drives > > the garbage collection of archived information and sandboxes."
modified. > On Jan. 17, 2015, 12:18 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, line 390 > > <https://reviews.apache.org/r/29896/diff/2/?file=824243#file824243line390> > > > > How about `--enforce_container_disk_quota`? Done. > On Jan. 17, 2015, 12:18 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, line 384 > > <https://reviews.apache.org/r/29896/diff/2/?file=824243#file824243line384> > > > > Whould we call this `--container_disk_watch_interval`? > > > > Still a bit concerned about the confusion with `--disk_watch_interval` > > which we can't change easily. Ideally we could also change it to > > `--gc_disk_watch_interval`. Done. > On Jan. 17, 2015, 12:18 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, line 392 > > <https://reviews.apache.org/r/29896/diff/2/?file=824243#file824243line392> > > > > enforcement for containers Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/#review68512 ----------------------------------------------------------- On Jan. 17, 2015, 12:41 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29896/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 12:41 a.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added a slave flag to turn off disk quota enforcement. > > > Diffs > ----- > > src/slave/containerizer/isolators/posix/disk.cpp > fcadd780f9d417f7422080a03cfbfc2e4d15f1b3 > src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4 > src/tests/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e > > Diff: https://reviews.apache.org/r/29896/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
