----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30006/#review68550 -----------------------------------------------------------
Bad patch! Reviews applied: [29560, 29809, 29560] Failed command: ./support/apply-review.sh -n -r 29560 Error: 2015-01-17 16:44:05 URL:https://reviews.apache.org/r/29560/diff/raw/ [46257/46257] -> "29560.patch" [1] error: patch failed: include/mesos/fetcher/fetcher.proto:23 error: include/mesos/fetcher/fetcher.proto: patch does not apply error: patch failed: include/mesos/mesos.proto:208 error: include/mesos/mesos.proto: patch does not apply error: patch failed: src/launcher/fetcher.cpp:283 error: src/launcher/fetcher.cpp: patch does not apply error: patch failed: src/slave/containerizer/docker.hpp:155 error: src/slave/containerizer/docker.hpp: patch does not apply error: patch failed: src/slave/containerizer/docker.cpp:222 error: src/slave/containerizer/docker.cpp: patch does not apply error: patch failed: src/slave/containerizer/fetcher.hpp:24 error: src/slave/containerizer/fetcher.hpp: patch does not apply error: patch failed: src/slave/containerizer/fetcher.cpp:16 error: src/slave/containerizer/fetcher.cpp: patch does not apply error: patch failed: src/slave/containerizer/mesos/containerizer.hpp:172 error: src/slave/containerizer/mesos/containerizer.hpp: patch does not apply error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:541 error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply error: patch failed: src/slave/flags.hpp:83 error: src/slave/flags.hpp: patch does not apply error: patch failed: src/tests/docker_containerizer_tests.cpp:293 error: src/tests/docker_containerizer_tests.cpp: patch does not apply error: patch failed: src/tests/fetcher_tests.cpp:57 error: src/tests/fetcher_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Jan. 17, 2015, 4:33 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30006/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 4:33 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Timothy Chen. > > > Bugs: MESOS-2057 > https://issues.apache.org/jira/browse/MESOS-2057 > > > Repository: mesos-git > > > Description > ------- > > Enables reuse of download results in the cache when multiple fetcher runs > occur concurrently. Optimizes for minimal number of fetcher runs, between 0 > and 2, depending on what is in the cache and what can be obtained from > concurrent runs by simply waiting for their already initiated downloads for > the same content to complete. > > > Diffs > ----- > > src/slave/containerizer/fetcher.hpp > 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp > 5993670f7899233efa1e6acef4b0c7856e32f748 > > Diff: https://reviews.apache.org/r/30006/diff/ > > > Testing > ------- > > make check, testing whether legacy direct fetching still works, using > existing tests. > > Testing of cache functionality coming in MESOS-2074. > > > Thanks, > > Bernd Mathiske > >
