----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30034/#review68626 -----------------------------------------------------------
Patch looks great! Reviews applied: [30033, 30034] All tests passed. - Mesos ReviewBot On Jan. 19, 2015, 3:51 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30034/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 3:51 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2069 > > > Repository: mesos-git > > > Description > ------- > > Makes the code structure of all fetcher tests the same. Instead of calling > the run mathod of the fetcher directly, calling through fetch(). Also removes > all uses of I/O redirection, which is not really needed for debugging, and > thus the next patch can refactor fetch() and run(). (The latter comes in two > varieties, which complicates matters without much benefit.) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 > > Diff: https://reviews.apache.org/r/30034/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
