----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30094/#review68797 -----------------------------------------------------------
src/tests/hook_tests.cpp <https://reviews.apache.org/r/30094/#comment113265> Need a newline here :-) src/tests/hook_tests.cpp <https://reviews.apache.org/r/30094/#comment113266> Move this into a new block, after the current block. src/tests/hook_tests.cpp <https://reviews.apache.org/r/30094/#comment113267> Does it make sense to have a newline here, now that we have more than just two statements? - Kapil Arya On Jan. 20, 2015, 4:38 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30094/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 4:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/tests/cluster.hpp 74cedb324949143fd1949082d8a4db596a32d95c > src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 > src/tests/mesos.hpp 591134bab31da0a1cc224e332666d05f320d0f87 > src/tests/mesos.cpp 3b98c69a604132be71a60fbbee4a47b51fe6956a > src/tests/slave_tests.cpp a85a0282947278ce6e02e38093f8b88af4cb612a > > Diff: https://reviews.apache.org/r/30094/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
