----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30097/#review68801 -----------------------------------------------------------
Ship it! src/examples/test_monitor_module.cpp <https://reviews.apache.org/r/30097/#comment113272> Do we need newlines here? src/tests/monitor_tests.cpp <https://reviews.apache.org/r/30097/#comment113273> newline here? - Kapil Arya On Jan. 20, 2015, 4:38 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30097/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 4:38 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Ported monitor tests to new monitor interface, changed it to a typed test and > wired up monitor module test. > > > Diffs > ----- > > src/examples/test_monitor_module.cpp PRE-CREATION > src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732 > > Diff: https://reviews.apache.org/r/30097/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
