----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29598/#review68804 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29598/#comment113274> How about moving this to it's own .proto file? - Niklas Nielsen On Jan. 19, 2015, 2:52 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29598/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 2:52 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [1/10] Build Mesos Modules outside Mesos source tree. > > To expose Modules message outside the mesos source tree. This allows modules > to #include mesos/mesos.hpp and get the required protobuf definition. > > > Diffs > ----- > > include/mesos/mesos.proto 859aa2fba2536b21dd2fe1f0baa2ae3417f63fdf > src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be > src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 > > Diff: https://reviews.apache.org/r/29598/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
