-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30036/#review68843
-----------------------------------------------------------



include/mesos/fetcher/fetcher.proto
<https://reviews.apache.org/r/30036/#comment113335>

    I had to go check when was FetcherInfo introduced as we normally don't want 
to change any assigned proto field ids. But since this is not released yet it's 
fine, commenting here if anyone trying to verify the same


- Timothy Chen


On Jan. 20, 2015, 9:33 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30036/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESO-2069
>     https://issues.apache.org/jira/browse/MESO-2069
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Extends the CommandInfo::URI protobuf with a boolean "caching" field that 
> will later cause fetcher cache actions. Also introduces the notion of a cache 
> directory to the fetcher info protobuf. And then propagates these additions 
> throughout the rest of the code base where applicable. This includes passing 
> the slave ID all the way down to the place where the cache dir name is 
> constructed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/fetcher/fetcher.proto 
> facb87b92bf3194516f636dcc348e136af537721 
>   include/mesos/mesos.proto 859aa2fba2536b21dd2fe1f0baa2ae3417f63fdf 
>   src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 
>   src/slave/containerizer/docker.hpp b7bf54ac65d6c61622e485ac253513eaac2e4f88 
>   src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 
>   src/slave/containerizer/fetcher.hpp 
> 1db0eaf002c8d0eaf4e0391858e61e0912b35829 
>   src/slave/containerizer/fetcher.cpp 
> 5993670f7899233efa1e6acef4b0c7856e32f748 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 802988c90ac872b0cefa5e28f06e6fec98e8d032 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d712278428889ebdfd598537690138329d8464f0 
>   src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9 
>   src/tests/docker_containerizer_tests.cpp 
> 2105ae2c410f01e7e0d10241d5c00df143fd3439 
>   src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 
> 
> Diff: https://reviews.apache.org/r/30036/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to