----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29974/#review68889 -----------------------------------------------------------
src/common/type_utils.hpp <https://reviews.apache.org/r/29974/#comment113422> The typical pattern I think is: ``` for (auto it = values.begin(); it != values.end(); ++it) { if (it != values.begin()) { stream << ", "; } stream << *iterator; } ``` But obviously both work. Just mentioning what I've seen in the past. - Michael Park On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29974/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 6:49 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added stream function for repeated protobuf messages. > > > Diffs > ----- > > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > > Diff: https://reviews.apache.org/r/29974/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
