> On Jan. 6, 2015, 2:08 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/socket.cpp, line 100 > > <https://reviews.apache.org/r/29528/diff/1/?file=805378#file805378line100> > > > > Mind adding a comment here and below, for what's going on in the > > different cases.
Great idea, thanks for the suggestion. > On Jan. 6, 2015, 2:08 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/socket.cpp, line 156 > > <https://reviews.apache.org/r/29528/diff/1/?file=805378#file805378line156> > > > > Mind adding a comment for what you are guarding against? Yes, thanks for the suggestion! > On Jan. 6, 2015, 2:08 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/socket.cpp, line 177 > > <https://reviews.apache.org/r/29528/diff/1/?file=805378#file805378line177> > > > > Why not inline _send? Oooh, nice, one less continuation necessary now, thanks Nik! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29528/#review66826 ----------------------------------------------------------- On Jan. 21, 2015, 5:42 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29528/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:42 p.m.) > > > Review request for mesos, Joris Van Remoortere and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ddb9e365fc1e65a568bdac4973964df1ab8cc05e > 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f > > Diff: https://reviews.apache.org/r/29528/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
