----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29569/#review68958 -----------------------------------------------------------
Bad patch! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539] Failed command: ./support/apply-review.sh -n -r 29539 Error: 2015-01-21 18:46:21 URL:https://reviews.apache.org/r/29539/diff/raw/ [19746/19746] -> "29539.patch" [1] error: patch failed: src/master/contender.cpp:233 error: src/master/contender.cpp: patch does not apply error: patch failed: src/master/detector.cpp:204 error: src/master/detector.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Jan. 21, 2015, 5:57 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29569/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:57 p.m.) > > > Review request for mesos, Joris Van Remoortere and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > The original once abstraction was implemented using promises, which made it > unusable to initialize libprocess because libprocess must be initialized in > order to use a Promise. This removes that requirement, but it also means that > an actor blocking on a Once will no longer donate it's thread while it's > waiting (since it doesn't wait on a Promise, which waits on a Latch, which > waits on a ProcessBase, which donates the thread while waiting). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/once.hpp > e85b38205065b34d438f68a6441905eb2f90169c > > Diff: https://reviews.apache.org/r/29569/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
