----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30110/#review68988 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30110/#comment113556> s/ts/messages 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30110/#comment113558> No need for this variable. The following is more clear: ``` foreach (const T& message, messages) { Try<Nothing> result = write(fd, message); if (result.isError()) { return Error(result.error()); } } return Nothing(); ``` 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30110/#comment113557> ``` foreach (const T& message, messages) { ... } ``` 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30110/#comment113555> Instead of having a helper, can you simply use this templated function as the new 'write' and kill the following two 'write's? - Jie Yu On Jan. 21, 2015, 10:19 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30110/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:19 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added support for `RepeatedPtrField` to `::protobuf::write`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > ff494c3da35a44ada703fa3997d89b4237495ef9 > > Diff: https://reviews.apache.org/r/30110/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
