> On Jan. 21, 2015, 10 p.m., Ben Mahler wrote:
> > Thanks Jie, mind including a bit of context in the review description next 
> > time? Perhaps a little NOTE in the code would make that unnecessary (i.e. 
> > that we can't overload because of a compilation issue on gcc-4.4).

Sure. Added a NOTE in the code.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30140/#review69031
-----------------------------------------------------------


On Jan. 21, 2015, 9:55 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30140/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:55 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2236
>     https://issues.apache.org/jira/browse/MESOS-2236
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed the build issue in collect.hpp for gcc-4.4.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> 6352883ccdfbede8cac22063d8c2e40bcc5f40cf 
> 
> Diff: https://reviews.apache.org/r/30140/diff/
> 
> 
> Testing
> -------
> 
> make check using gcc-4.4.7
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to