> On Jan. 21, 2015, 12:43 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 1326 > > <https://reviews.apache.org/r/29973/diff/2/?file=827013#file827013line1326> > > > > framework id will be empty for REGISTER event. > > Jie Yu wrote: > Yes. If id is not set (REGISTER call), then a null string will be printed > (default value in protobuf). I think that's fine, right?
It's just that for REGISTER call it will look like "Dropping REGISTER call from framework (foobar) at [email protected]:8080" vs "Dropping ACCEPT call from framework 2101-29890-9291523-1245 (foobar) at [email protected]:8080" I guess that's not too bad because we might print the name and will print the pid. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29973/#review68814 ----------------------------------------------------------- On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29973/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 6:49 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Passed framework ID instead framework info to Master::receive. > > > Diffs > ----- > > src/master/master.hpp a8ce4d023ddea36cb83a2dc7b95abd12342f345a > src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 > > Diff: https://reviews.apache.org/r/29973/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
