> On Jan. 21, 2015, 6:16 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 300 > > <https://reviews.apache.org/r/30109/diff/1/?file=827850#file827850line300> > > > > Not your fault, but should we use: > > > > ```S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH```? > > Michael Park wrote: > Probably a good idea. I'm not sure if I should just update this patch or > make a pass at the codebase since I see this pattern all over from a quick > grep. What do you think? > > Jie Yu wrote: > Yeah, please follow up with a patch to get those corrected. Maybe create > a ticket first?
JIRA Ticket: https://issues.apache.org/jira/browse/MESOS-2240 stout (this depends on it): https://reviews.apache.org/r/30143/ libprocess: https://reviews.apache.org/r/30144/ mesos: https://reviews.apache.org/r/30145/ - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30109/#review68948 ----------------------------------------------------------- On Jan. 21, 2015, 10:25 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30109/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:25 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added `O_CLOEXEC` flag and fixed formatting in `os::write`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0446f6a5d5628f8566d4cbaf33dee29b52c3c42e > > Diff: https://reviews.apache.org/r/30109/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
