----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30131/#review69103 -----------------------------------------------------------
include/mesos/resources.hpp <https://reviews.apache.org/r/30131/#comment113725> I'm curious why you chose to stray from the existing Filter design in resources.cpp, I like that one because it can live entirely outside the 'Resources' abstraction (doesn't need to be a member function, can be an outside class in this file). This one seems a bit trickier, since you have to deal with some ambiuity around what it means to filter (i.e. if you want to filter x, does that mean you keep x or remove x? To me I think of the latter), unless we rename 'filter' to predicate. src/common/resources.cpp <https://reviews.apache.org/r/30131/#comment113707> Can you consolidate this one with what you're adding? - Ben Mahler On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30131/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 6:12 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Used persistent volumes consistently in the code base. (previously, we used > persistent disk). > > > Diffs > ----- > > include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f > src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b > src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33 > src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 > src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be > src/slave/containerizer/isolators/posix/disk.cpp > bb1779fd644a33527068868a45cf9c19d7732727 > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a > src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 > > Diff: https://reviews.apache.org/r/30131/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
