> On Jan. 23, 2015, 6:52 a.m., Michael Park wrote: > > > > Michael Park wrote: > Looks good overall to me, a few minor comments. > One question: did you not like the generalized logic of `result -= > source; result += target;`? > I'm asking so that I know whether I should generalize it when I go to > implement the dynamic reservation parts or not. > > Jie Yu wrote: > What's 'source' and what's 'target'? It's still case by case, so I would > rather not to generalize it to make code more localized (thus more readable).
Ok. > On Jan. 23, 2015, 6:52 a.m., Michael Park wrote: > > src/common/resources.cpp, lines 627-631 > > <https://reviews.apache.org/r/30130/diff/2/?file=831197#file831197line627> > > > > Shouldn't the `validate` function above cover these cases? > > Jie Yu wrote: > The Resources::validate function is only used to verify the integrety of > each Resource object (e.g., name='cpu' but has DiskInfo, etc). The validation > here is high level checks (i.e., each Resource object is valid, but shoudn't > be part of this operation). Ah ok. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30130/#review69354 ----------------------------------------------------------- On Jan. 23, 2015, 5:16 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30130/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 5:16 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Removed Resources::Transformation in favor of using Offer::Operation. > > This patch is based on and is a replacement for > https://reviews.apache.org/r/29744/ > > > Diffs > ----- > > include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f > src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b > src/master/allocator.hpp 224569a55eb15d9e7c63f2b571a1f9ae8cd4b6e6 > src/master/drf_sorter.hpp e0ec58b1095b64f76f6aa4bf1e5d48a77bdf777f > src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33 > src/master/hierarchical_allocator_process.hpp > ccd37b4348c785ece890257f805777acbaf8d58c > src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13 > src/master/sorter.hpp 333c2934b1ee01c94bc77b02b607efc438589bd6 > src/tests/hierarchical_allocator_tests.cpp > 7c051232f2c70691a7789e0f3e94f0e4cba26f18 > src/tests/mesos.hpp 591134bab31da0a1cc224e332666d05f320d0f87 > src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a > src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 > > Diff: https://reviews.apache.org/r/30130/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
