----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30192/#review69454 -----------------------------------------------------------
Ship it! LGTM. 3rdparty/libprocess/include/process/limiter.hpp <https://reviews.apache.org/r/30192/#comment114161> what do you mean by "next permit takes it place"? Do you mean the next caller takes the permit? 3rdparty/libprocess/include/process/limiter.hpp <https://reviews.apache.org/r/30192/#comment114159> Not your fault, this should be 'else if' 3rdparty/libprocess/src/tests/limiter_tests.cpp <https://reviews.apache.org/r/30192/#comment114162> The comments is confusing. IIUC, we don't discard the permit, we discard the 'acquire' of the permit, right? 3rdparty/libprocess/src/tests/limiter_tests.cpp <https://reviews.apache.org/r/30192/#comment114164> This test might be flaky if 'AWAIT_READY(acquire1)' takes longer (unlikely), right? It would be great if we can pause the clock for this test since timing is very important for this test. - Jie Yu On Jan. 23, 2015, 12:46 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30192/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 12:46 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-2230 > https://issues.apache.org/jira/browse/MESOS-2230 > > > Repository: mesos-git > > > Description > ------- > > I tried/implemented a complex solution involving list iterators and removing > discarded promises from the list, but it was hard to reason about the > correctness and race conditions. So abandoned it in favor of a simpler > solution. Let me know what you think. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/limiter.hpp > a1c4f189565003f19f8b33c3b8a81e28836069c1 > 3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30192/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
