----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/#review69741 -----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp <https://reviews.apache.org/r/29289/#comment114508> Let's take `_ip` by constant reference now that it's larger than 8 bytes. 3rdparty/libprocess/include/process/pid.hpp <https://reviews.apache.org/r/29289/#comment114509> const ref. 3rdparty/libprocess/include/process/pid.hpp <https://reviews.apache.org/r/29289/#comment114510> const ref. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114511> Missing period. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114512> Missing period. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114513> It seems like we have helper functions to deal with addresses now that switch on the family and abstract these kinds of things away. Can we follow the same pattern and not have exceptions like this one? If we add another family then this will likely be missed and turn into a bug. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114514> same as above. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114515> Can we change this error style to "on: " + stringify(node)? 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114519> Would it make sense to provide a constructor in net::IP::InAddrStorage that takes family, or an enum and default constructs correctly? This seems like a repetitive, error prone pattern right now. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29289/#comment114520> I don't know what the style rule is from `(sockaddr_in6*)`, but it's inconsistent with the case above. - Joris Van Remoortere On Jan. 26, 2015, 6:56 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29289/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 6:56 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/node.hpp > 173eb8abe0d0930c92f261be7a95e07b1d4c16af > 3rdparty/libprocess/include/process/pid.hpp > 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 > 3rdparty/libprocess/include/process/socket.hpp > ddb9e365fc1e65a568bdac4973964df1ab8cc05e > 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 > 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d > 3rdparty/libprocess/src/process.cpp > 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf > 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f > > Diff: https://reviews.apache.org/r/29289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
