----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30294/#review69769 -----------------------------------------------------------
Kapil, why do we go here for includes instead of fwd declarations? A golden rule for small compilation times is to use fwd declarations whenever possible (especially in headers). Here is a good article on this topic: http://herbsutter.com/2013/08/19/gotw-7a-solution-minimizing-compile-time-dependencies-part-1/ - Alexander Rukletsov On Jan. 27, 2015, 1:25 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30294/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 1:25 a.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Timothy > Chen. > > > Bugs: MESOS-2272 > https://issues.apache.org/jira/browse/MESOS-2272 > > > Repository: mesos-git > > > Description > ------- > > Removed forward decls by adding required headers to common/http.hpp. > > > Diffs > ----- > > src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 > > Diff: https://reviews.apache.org/r/30294/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
