----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/#review69835 -----------------------------------------------------------
docs/configuration.md <https://reviews.apache.org/r/30195/#comment114638> s/two/three/ docs/configuration.md <https://reviews.apache.org/r/30195/#comment114637> this is clumsy. maybe: "... where the file 'foo' must contain the value." note - is this a json format with key-value pairs? can i set a simple string/int value with this? will this eventually allow us to move to a configuration file that has all options as keys and values as values? :) docs/configuration.md <https://reviews.apache.org/r/30195/#comment114639> this is a really subtle api change and needs some thought. what if i want to specify a protocol like hdfs? must this be a local file? can i pass a relative path? docs/configuration.md <https://reviews.apache.org/r/30195/#comment114640> s/seperated/separated/ src/credentials/credentials.hpp <https://reviews.apache.org/r/30195/#comment114641> can you please create jira tickets for these TODOs? src/credentials/credentials.hpp <https://reviews.apache.org/r/30195/#comment114643> don't use inline here. trust the compiler. src/master/detector.cpp <https://reviews.apache.org/r/30195/#comment114644> this should be CHECK, i believe. src/watcher/whitelist_watcher.cpp <https://reviews.apache.org/r/30195/#comment114645> CHECK src/zookeeper/url.hpp <https://reviews.apache.org/r/30195/#comment114646> keep the * with the type. also, why is this a method? static const char prefix[] = "zk://"; will work fine. - Dominic Hamon On Jan. 27, 2015, 9:26 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30195/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 9:26 a.m.) > > > Review request for mesos, Benjamin Hindman and Ken Sipe. > > > Bugs: mesos-1806 > https://issues.apache.org/jira/browse/mesos-1806 > > > Repository: mesos-git > > > Description > ------- > > Mostly simplifies things. There are two places where there things get > complicated > > 1. --whitelist: This code wants a file to watch for changes and update > the whitelist from periodically. Now you have to specify that path > without a 'file://' prefix since the file:// prefix would read the > value out of a file. > 2. --credential, --credentials: Custom parsing logic since the > credentials can be given in two different formats. Once the old > format is removed, either teaching <stout/flags> how to parse json > to protobuf generally or taking the flag as JSON then converting it > to protobuf later will make this clean. > > > Diffs > ----- > > CHANGELOG a4036273fb8a1af119e2ba66f9440dc0c36c87c4 > docs/configuration.md 8a55f631b7cabcc075cb496d70de87384fa79eae > src/credentials/credentials.hpp 4cdadb1b6d5a607cee8caeb38f2cbf2e3ec5da7a > src/examples/load_generator_framework.cpp > 01a567b424140575ae0c369d026589300f173143 > src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 > src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15 > src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d > src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b > src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 > src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > src/tests/credentials_tests.cpp 091b545c11cfa9deabf710366e15cfc0b966de0f > src/tests/master_allocator_tests.cpp > 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea > src/tests/master_contender_detector_tests.cpp > d847a30d21b2a2980c6b7ceb62bbf61dc77487de > src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed > src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2 > src/watcher/whitelist_watcher.cpp b6e73d7f500931dec69f115e554f9cd7cb42c3ed > src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf > > Diff: https://reviews.apache.org/r/30195/diff/ > > > Testing > ------- > > make distcheck > - Tests not hitting the file:// handling which was replaced with assert() > statements. > > > Thanks, > > Cody Maloney > >
