----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30328/#review69908 -----------------------------------------------------------
Patch looks great! Reviews applied: [30328] All tests passed. - Mesos ReviewBot On Jan. 27, 2015, 9:57 p.m., David Robinson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30328/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 9:57 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2193 > https://issues.apache.org/jira/browse/MESOS-2193 > > > Repository: mesos-git > > > Description > ------- > > Added external_log_file option. > > This is a continuation of the review started here: > https://reviews.apache.org/r/29071 > > > Diffs > ----- > > src/logging/flags.hpp 11efb84cc2c509f852f8ba20f16a366b4cb5810f > src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8 > src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f > src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > src/webui/master/static/js/controllers.js > 41a70a80442501a2bf7b217939dbe504662941d2 > > Diff: https://reviews.apache.org/r/30328/diff/ > > > Testing > ------- > > Ran locally. > > > Thanks, > > David Robinson > >
