-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30338/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 9:13 p.m.)


Review request for mesos, Ian Downes, nnichddq nnichddq, Till Toenshoff, and 
Vinod Kone.


Changes
-------

Addressed Ian's comments.


Summary (updated)
-----------------

Introduced ExecutorRunState struct for Isolators and Launchers.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[4/9] Build Mesos Modules outside Mesos source tree.

The struct is constructed from some fields of RunState and passed on to
Isolators.  This further allows us to do cleanup various isolators/launchers.
The goal was to remove the dependency on RunState so that we
can eventually expose slave/containerizer/isolator.hpp as a public header.


Diffs (updated)
-----

  src/slave/containerizer/isolator.hpp a27c3e955ff25b87599af0ac2c97427a88b786f6 
  src/slave/containerizer/isolator.cpp 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 
  src/slave/containerizer/isolators/cgroups/cpushare.hpp 
4ded0c4678ad61742a69e14233006a448f3fc3ca 
  src/slave/containerizer/isolators/cgroups/cpushare.cpp 
90aabb85da452a3a508888f738379a73b7465dc6 
  src/slave/containerizer/isolators/cgroups/mem.hpp 
2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
711d66d7771cac13be831d73af3ef570d6785473 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 
e511c3efe4cc4ec13cc74bdcda993477a4db2e36 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
6f67164d3963769148fb1749d1d590b7b2999fdb 
  src/slave/containerizer/isolators/filesystem/shared.hpp 
727f63e16fa69293c472a4b6b95fb0be04e689c8 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
5c347af803bf512698dd580d6533c0103b289427 
  src/slave/containerizer/isolators/namespaces/pid.hpp 
8da6cccff04edf11fa37f5a33648821299cf49d5 
  src/slave/containerizer/isolators/namespaces/pid.cpp 
fdd430e946c386e37ffc5b24907063180cddac17 
  src/slave/containerizer/isolators/network/port_mapping.hpp 
90d19a95092bc18c1077fbaec9ebf9c87291474c 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
b484bbf34060ccc9debd48a3e840c03c8f95de09 
  src/slave/containerizer/isolators/posix.hpp 
7a667e3e30712b98484947520b58965d3b768659 
  src/slave/containerizer/isolators/posix/disk.hpp 
cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732 
  src/slave/containerizer/isolators/posix/disk.cpp 
bb1779fd644a33527068868a45cf9c19d7732727 
  src/slave/containerizer/launcher.hpp 18b3546a5e51e8a3819bca11630f699a0aadf762 
  src/slave/containerizer/launcher.cpp 92c0657728ddb9f6a4f9065ff8a7093c5371bc6f 
  src/slave/containerizer/linux_launcher.hpp 
3d9794dd4983ecf59833f3971cbb094d4bf7710f 
  src/slave/containerizer/linux_launcher.cpp 
10c12039cf684bef9398da72c3eceb9ed8b8b9c9 
  src/slave/containerizer/mesos/containerizer.hpp 
802988c90ac872b0cefa5e28f06e6fec98e8d032 
  src/slave/containerizer/mesos/containerizer.cpp 
d712278428889ebdfd598537690138329d8464f0 
  src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 

Diff: https://reviews.apache.org/r/30338/diff/


Testing
-------

make check.


Thanks,

Kapil Arya

Reply via email to