----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30353/#review69957 -----------------------------------------------------------
Patch looks great! Reviews applied: [30352, 30353] All tests passed. - Mesos ReviewBot On Jan. 28, 2015, 3:06 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30353/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 3:06 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-2283 > https://issues.apache.org/jira/browse/MESOS-2283 > > > Repository: mesos-git > > > Description > ------- > > There was a race in the cluster shutdown code: after we obtain the set of > containers and before call 'wait' on each one, some containers may terminate, > which leads to a 'wait' failure. > > This fixes the flaky SlaveRecoveryTest.ReconcileKillTask test in MESOS-2283. > > > Diffs > ----- > > src/tests/cluster.hpp 74cedb324949143fd1949082d8a4db596a32d95c > > Diff: https://reviews.apache.org/r/30353/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
