> On Jan. 23, 2015, 5:01 p.m., Adam B wrote: > > include/mesos/fetcher/fetcher.proto, lines 44-45 > > <https://reviews.apache.org/r/30037/diff/6/?file=829684#file829684line44> > > > > How does this fail for an item not present in the cache? Why wouldn't > > you just want to check for presence in the cache, retrieve if present and > > download&cache if absent? > > Bernd Mathiske wrote: > Because I already know what's in the cache and what isn't. This > bookkeeping is NOT in mesos-fetcher, to which this is a parameter. It is in > FetcherProcess, which is in the slave. > > Adam B wrote: > Is there a writeup somewhere about what responsibilties fall in the realm > of the FetcherProcess vs. mesos-fetcher? It would be interesting to know > (especially as an implementer of an external/module fetcher) what state/logic > belongs where, so that the API between the two is clear. > > Bernd Mathiske wrote: > I'll find a good place for that writeup and put it there.
Actually, there is such a comment in one of the later reviews. I could pull it forward to here, but then it would either mention stuff that's not in this version yet or it would change later. This is in src/launcher/fetcher.cpp, above main(), explaining what mesos-fetcher does. I'll make sure I later also have a counterpart in containerizer/fetchr.hpp! - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30037/#review69514 ----------------------------------------------------------- On Jan. 25, 2015, 9:44 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30037/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 9:44 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2069 > > > Repository: mesos-git > > > Description > ------- > > Extends the fetcher info protobuf with "actions" (fetch directly, through > cache, retrieve from cache). Switches the basis for dealing with uris to > "items", which contain the uri, the action, and potentially and cache file > name. Refactors fetch() and run(), so there is only one of each. Introduces > about half of the actual cache logic, including a hashmap of cache file > objects for bookkeeping and basic operations on it. > > > Diffs > ----- > > include/mesos/fetcher/fetcher.proto > facb87b92bf3194516f636dcc348e136af537721 > src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 > src/slave/containerizer/fetcher.hpp > 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp > d290f95251def3952c5ee34f600e1d71467f6293 > > Diff: https://reviews.apache.org/r/30037/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
