----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28775/#review70065 -----------------------------------------------------------
Overall, looks good! Instead of adding a test in master allocation tests, could you please instead kill this TODO in resource offer tests: ``` // TODO(benh): Add tests which launch multiple tasks and check for // aggregate resource usage. ``` - Jie Yu On Jan. 28, 2015, 7:45 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28775/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 7:45 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > With the new `Offer::Operation`s that modify the offered resources, the > existing task validation breaks. This fixes that. > > > Diffs > ----- > > src/master/master.hpp 1d342e56116ad63aade43484b6899ce26f25abfd > src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f > src/tests/master_allocator_tests.cpp > 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea > > Diff: https://reviews.apache.org/r/28775/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
