----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30348/#review70067 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/30348/#comment115023> This will race with clearAllCallbacks if one thread is calling f.discard() and another thread is setting/failing the future. - Jie Yu On Jan. 28, 2015, 1:35 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30348/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 1:35 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2279 > https://issues.apache.org/jira/browse/MESOS-2279 > > > Repository: mesos-git > > > Description > ------- > > This is important so that the callbacks of a future can hold a reference to > the same future. If we don't clear the callback, the future will never get > gc'ed. See bug for details. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 0326b23cdd475c6e86b33f9b4c63136fdecab443 > > Diff: https://reviews.apache.org/r/30348/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
