----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30298/#review70103 -----------------------------------------------------------
Ship it! Thanks Jie, we probably want to consider moving towards functions for these validators. Can you add a TODO, at least for 'ResourcesValidator'? src/master/master.cpp <https://reviews.apache.org/r/30298/#comment115086> Could we try to make these messages consistent? Unfortunately, we can't get the prefix in the message, so let's stick it in here: ``` "Invalid DiskInfo: '*' role not supported for persistent volume" "Invalid DiskInfo: expecting 'volume' to be present" "Invalid DiskInfo: read-only volume not supported" "Invalid DiskInfo: expecting 'host_path' to be unset" "Invalid DiskInfo: 'persistence.id' 'XXX' contains invalid characters" "Invalid DiskInfo: expecting 'persistence.id' to be set when 'volume' is set" "Invalid DiskInfo: expecting 'volume' to be set" ``` src/master/master.cpp <https://reviews.apache.org/r/30298/#comment115087> Maybe: "Invalid Persistence ID: 'XXX' is not unique" - Ben Mahler On Jan. 27, 2015, 9:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30298/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 9:27 p.m.) > > > Review request for mesos, Ben Mahler and Michael Park. > > > Repository: mesos-git > > > Description > ------- > > Pull resources validation info separate validators so that we can leverage > them to validate resources in other Offer Operations as well. > > > Diffs > ----- > > src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f > > Diff: https://reviews.apache.org/r/30298/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
